Migrating ITs to Testcontainers#1673
Conversation
|
@dapr/maintainers-java-sdk and @dapr/approvers-java-sdk could you please take a look and let me know if it is looking good. |
|
@salaboy @javier-aliaga @cicoyle let me know if you think this is a good idea. |
|
I think it's a great idea, we just need to do it in the right way, let me check your changes on Monday and get back to you |
artur-ciocanu
force-pushed
the
testconainers-appocalypse
branch
from
195598e to
823a79b
Compare
|
@artur-ciocanu I think something is broken the build with sb 3.5 never finishes. Also lets wait to merge this until we get the new release out 🙏 |
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
artur-ciocanu
force-pushed
the
testconainers-appocalypse
branch
from
6953b1b to
58e6419
Compare
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
============================================
- Coverage 79.53% 79.51% -0.02%
- Complexity 2193 2194 +1
============================================
Files 237 237
Lines 6577 6577
Branches 730 730
============================================
- Hits 5231 5230 -1
- Misses 990 992 +2
+ Partials 356 355 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am closing this PR for now, I will try a more step by step approach. |
4 participants
Description
This makes sure that all ITs are migrated to Testcontainers.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: